This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Don't use Bash-specific ${parameter/pattern/string} expansion
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: "Patrick 'P. J.' McDermott" <pj+sourceware-ml at pehjota dot net>
- Cc: <libc-alpha at sourceware dot org>
- Date: Mon, 9 Sep 2013 13:34:36 +0000
- Subject: Re: [PATCH] Don't use Bash-specific ${parameter/pattern/string} expansion
- Authentication-results: sourceware.org; auth=none
- References: <522CDBAD dot 8000104 at pehjota dot net>
On Sun, 8 Sep 2013, Patrick 'P. J.' McDermott wrote:
> There's one other instance of this expansion syntax in the glibc tree
> (scripts/cross-test-ssh.sh:106), but that file isn't used during the
> build.
More significantly, it's explicitly a bash script (#! /bin/bash), whereas
make-syscalls.sh uses #! /bin/sh and is run with $(SHELL). Use of
bash-specific syntax is only a bug when used in an sh script (#! /bin/sh,
run with $(SHELL)). Although since we don't document bash as a build
requirement in install.texi, if any bash scripts are required for the
build there's at least a documentation bug.
--
Joseph S. Myers
joseph@codesourcery.com