This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Don't use Bash-specific ${parameter/pattern/string} expansion


On Sun, 8 Sep 2013, Patrick 'P. J.' McDermott wrote:

> There's one other instance of this expansion syntax in the glibc tree
> (scripts/cross-test-ssh.sh:106), but that file isn't used during the
> build.

More significantly, it's explicitly a bash script (#! /bin/bash), whereas 
make-syscalls.sh uses #! /bin/sh and is run with $(SHELL).  Use of 
bash-specific syntax is only a bug when used in an sh script (#! /bin/sh, 
run with $(SHELL)).  Although since we don't document bash as a build 
requirement in install.texi, if any bash scripts are required for the 
build there's at least a documentation bug.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]