This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/2 v3] tst-fanotify: new simple test
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: <libc-alpha at sourceware dot org>, Andreas Schwab <schwab at linux-m68k dot org>, Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- Date: Tue, 3 Sep 2013 22:40:20 +0000
- Subject: Re: [PATCH 1/2 v3] tst-fanotify: new simple test
- Authentication-results: sourceware.org; auth=none
- References: <1377100993-9438-1-git-send-email-vapier at gentoo dot org> <201309031626 dot 19295 dot vapier at gentoo dot org> <Pine dot LNX dot 4 dot 64 dot 1309032108160 dot 27960 at digraph dot polyomino dot org dot uk> <201309031811 dot 36650 dot vapier at gentoo dot org>
On Tue, 3 Sep 2013, Mike Frysinger wrote:
> On Tuesday 03 September 2013 17:08:47 Joseph S. Myers wrote:
> > On Tue, 3 Sep 2013, Mike Frysinger wrote:
> > > short of doing a AC_CHECK_HEADER, i don't see a solution here.
> >
> > Increase the required headers version (would need proposing in a separate
> > thread with its own subject).
>
> i think adding an AC_CHECK_HEADER is better than bumping the min build kernel
> version to 2.6.37 (i think that's the first release to include this). seems
> unreasonable to move that far ahead for a single (minor) test.
The benefits of a more recent version go beyond the one test - they mean
much more generally that code doesn't need #ifdef conditionals on __NR_*
if all architectures are sure to have the macro defined when a newer
kernel headers version is in use, for example.
--
Joseph S. Myers
joseph@codesourcery.com