This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] benchtests/Makefile: Use LDLIBS instead of LDFLAGS.


On Tue, Sep 03, 2013 at 05:43:06PM +0100, Will Newton wrote:
> On 2 September 2013 15:37, Siddhesh Poyarekar <siddhesh@redhat.com> wrote:
> > On Mon, Sep 02, 2013 at 03:20:26PM +0100, Will Newton wrote:
> >>
> >> LDFLAGS puts the library too early in the command line if --as-needed
> >> is being used. Use LDLIBS instead.
> >>
> >> ChangeLog:
> >>
> >> 2013-09-02  Will Newton  <will.newton@linaro.org>
> >>
> >>       * benchtests/Makefile: Use LDLIBS instead of LDFLAGS.
> >> ---
> >>  benchtests/Makefile | 32 ++++++++++++++++----------------
> >>  1 file changed, 16 insertions(+), 16 deletions(-)
> >
> > Looks good to me.
> 
> Is it ok to go ahead and commit?

Yes, unless you would like additional review.

Siddhesh


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]