This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [COMMITED] faster memcpy on x64.
- From: Andreas Jaeger <aj at suse dot com>
- To: Liubov Dmitrieva <liubov dot dmitrieva at gmail dot com>
- Cc: OndÅej BÃlka <neleai at seznam dot cz>, GNU C Library <libc-alpha at sourceware dot org>, "H.J. Lu" <hjl dot tools at gmail dot com>
- Date: Mon, 02 Sep 2013 13:30:27 +0200
- Subject: Re: [COMMITED] faster memcpy on x64.
- Authentication-results: sourceware.org; auth=none
- References: <20130427221620 dot GA16537 at domone dot kolej dot mff dot cuni dot cz> <518BB251 dot 7040602 at suse dot com> <CAHjhQ93bxAexzbymP6GN-08wLiu9mdxf2MoCXgqA1v-ONYJdFw at mail dot gmail dot com> <CAHjhQ90BGDy1XVWUQui8Tx7PzO0Y6pUAEBXHxTqXH8NAbBGvHw at mail dot gmail dot com> <51927FB1 dot 1070904 at suse dot com> <20130520081458 dot GB814 at domone dot kolej dot mff dot cuni dot cz> <CAHjhQ916H83byoyeNnSzMvd7nHqeUp=TqyMuQE0j8hjcAx7_tg at mail dot gmail dot com>
On 08/29/2013 04:45 PM, Liubov Dmitrieva wrote:
> And you forgot to remove the version which is never used now as memcpy
> from the ifunc-impl-list:
>
>
> diff --git a/sysdeps/x86_64/multiarch/ifunc-impl-list.c
> b/sysdeps/x86_64/multiarch/ifunc-impl-list.c
> index 28d3579..d6a7f4f 100644
> --- a/sysdeps/x86_64/multiarch/ifunc-impl-list.c
> +++ b/sysdeps/x86_64/multiarch/ifunc-impl-list.c
> @@ -224,8 +224,6 @@ __libc_ifunc_impl_list (const char *name, struct
> libc_ifunc_impl *array,
>
> /* Support sysdeps/x86_64/multiarch/memcpy.S. */
> IFUNC_IMPL (i, name, memcpy,
> - IFUNC_IMPL_ADD (array, i, memcpy, HAS_SSSE3,
> - __memcpy_ssse3_back)
> IFUNC_IMPL_ADD (array, i, memcpy, HAS_SSSE3, __memcpy_ssse3)
> IFUNC_IMPL_ADD (array, i, memcpy, 1, __memcpy_sse2_unaligned)
> IFUNC_IMPL_ADD (array, i, memcpy, 1, __memcpy_sse2))
This is fine. Liubov and Ondrej, have you taken care of it?
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 NÃrnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix ImendÃrffer,HRB16746 (AG NÃrnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126