This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Potential issue with strstr on x86 with sse4.2 in glibc-2.18
- From: Rich Felker <dalias at aerifal dot cx>
- To: Alexander Monakov <amonakov at ispras dot ru>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 19 Aug 2013 12:37:12 -0400
- Subject: Re: Potential issue with strstr on x86 with sse4.2 in glibc-2.18
- References: <520E181D dot 2040308 at archlinux dot org> <alpine dot LNX dot 2 dot 00 dot 1308191628370 dot 2626 at monopod dot intra dot ispras dot ru> <20130819144648 dot GF20515 at brightrain dot aerifal dot cx> <alpine dot LNX dot 2 dot 00 dot 1308191924490 dot 2626 at monopod dot intra dot ispras dot ru>
On Mon, Aug 19, 2013 at 07:54:22PM +0400, Alexander Monakov wrote:
> On Mon, 19 Aug 2013, Rich Felker wrote:
> > Really this doesn't even look like a case of a legacy binary, but
> > rather fglrx's libGL.so.1 simply containing incorrect asm (or just
> > CFLAGS?) that doesn't match the modern psABI calling convention. It
> > would probably be best to pressure its maintainers to fix this bug on
> > their side...
>
> I'm afraid what's more likely to happen in practice is distributions being
> pressured by users to pick up the patch reinstating the inline keywords in
> strstr.c. Allan, what are you going to do in Arch Linux about this? Keep
> patching upstream, or drop the patch, let FGLRX break and tell users to
> complain to AMD, or... ? [I do realize that the two former options are bad]
As far as I can tell, adding the inline keywords back is not a fix,
it's just a perturbation of gcc's behavior that happens to re-mask the
bug. It could really come back at any time depending on compiler
version, CFLAGS, etc.
Rich