This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] Remove remains of rwlock elision which is not implemented yet.


On 07/19/2013 01:39 AM, Dominik Vogt wrote:
> First patch of minor cleanup of the lock elision patches.  This
> one removes the unused tuning variables for rwlock elision (one of
> them has a prototype in the header file, the other has not).
> 
> Ciao
> 
> Dominik ^_^  ^_^
> 
> -- Dominik Vogt IBM Germany
 
Looks good to me.

Thanks for the cleanup.

I'm feeling extra perky this morning so I've added a ChangeLog
for you and checked this in (it might also be the lack of sleep
or the fact that git am'able diffs are easy to apply and made
me happy).

In the future please please follow the contribution checklist:
http://sourceware.org/glibc/wiki/Contribution%20checklist

You can keep sending git-am'able patches if you wish, but adding
a ChangeLog in your main email helps me such that when I tack 
on the ChangeLog it's easy to do.

e.g.
git am -s your.patch
git reset --soft HEAD^
edit ChangeLog
git commit -c ORIG_HEAD
 
> 0001-Remove-remains-of-rwlock-elision-which-is-not-implem.patch
> 
> 
> From 315f4ead5f091bc31dcd7dc944e353ef3972fa51 Mon Sep 17 00:00:00 2001
> From: Dominik Vogt <vogt@de.ibm.com>
> Date: Fri, 19 Jul 2013 05:02:44 +0000
> Subject: [PATCH 1/2] Remove remains of rwlock elision which is not
>  implemented yet.
> 
> ---
>  nptl/sysdeps/unix/sysv/linux/x86/elision-conf.c | 10 ----------
>  nptl/sysdeps/unix/sysv/linux/x86/elision-conf.h |  1 -
>  2 files changed, 11 deletions(-)
> 
> diff --git a/nptl/sysdeps/unix/sysv/linux/x86/elision-conf.c b/nptl/sysdeps/unix/sysv/linux/x86/elision-conf.c
> index 118cfa7..822d4bd 100644
> --- a/nptl/sysdeps/unix/sysv/linux/x86/elision-conf.c
> +++ b/nptl/sysdeps/unix/sysv/linux/x86/elision-conf.c
> @@ -43,15 +43,6 @@ struct elision_config __elision_aconf =
>      .skip_trylock_internal_abort = 3,
>    };
>  
> -/* Elided rwlock toggle, set when elision is available and is
> -   enabled for rwlocks.  */
> -
> -int __rwlock_rtm_enabled attribute_hidden;
> -
> -/* Retries for elided rwlocks on read. Conservative initial value.  */
> -
> -int __rwlock_rtm_read_retries attribute_hidden = 3;
> -
>  /* Set when the CPU supports elision. When false elision is never attempted.  */
>  
>  int __elision_available attribute_hidden;
> @@ -73,7 +64,6 @@ elision_init (int argc __attribute__ ((unused)),
>    __elision_available = HAS_RTM;
>  #ifdef ENABLE_LOCK_ELISION
>    __pthread_force_elision = __libc_enable_secure ? 0 : __elision_available;
> -  __rwlock_rtm_enabled = __libc_enable_secure ? 0 : __elision_available;
>  #endif
>  }
>  
> diff --git a/nptl/sysdeps/unix/sysv/linux/x86/elision-conf.h b/nptl/sysdeps/unix/sysv/linux/x86/elision-conf.h
> index 55b81db..6fa2697 100644
> --- a/nptl/sysdeps/unix/sysv/linux/x86/elision-conf.h
> +++ b/nptl/sysdeps/unix/sysv/linux/x86/elision-conf.h
> @@ -34,7 +34,6 @@ struct elision_config
>  
>  extern struct elision_config __elision_aconf attribute_hidden;
>  
> -extern int __rwlock_rtm_enabled attribute_hidden;
>  extern int __elision_available attribute_hidden;
>  extern int __pthread_force_elision attribute_hidden;
>  
> -- 1.7.11.4


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]