This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: requiring text format for patch attachments?
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Paul Eggert <eggert at cs dot ucla dot edu>
- Cc: Chris Metcalf <cmetcalf at tilera dot com>, GLIBC Devel <libc-alpha at sourceware dot org>
- Date: Fri, 28 Jun 2013 17:44:12 -0400
- Subject: Re: requiring text format for patch attachments?
- References: <CABXK9nfhHHnm+4LLnrtW-=Py69WvwcF3BWt-kf-TNHsPvqa5ig at mail dot gmail dot com> <51CD9D3B dot 8090002 at tilera dot com> <51CDDD8D dot 9010104 at systemhalted dot org> <51CDE1BE dot 2020501 at tilera dot com> <51CDFB6F dot 5020700 at cs dot ucla dot edu>
On 06/28/2013 05:09 PM, Paul Eggert wrote:
> On 06/28/2013 12:19 PM, Chris Metcalf wrote:
>> It might be useful to mention something about attachments being helpful to avoid
>> whitespace damage too, in addition to wrapping damage.
>
> I boldly installed the following wording into the checklist;
> please feel free to fix it if I messed up.
>
> * You can include the patch as part of the text of the email; that's
> often easier.
>
> * If your mailer insists on wrapping long lines or otherwise altering
> patch contents, or if the diff might cause problems due to binary
> data or mixed encodings, attach the patch to the email. The
> attachment should normally employ a Content-Type of text/x-diff or
> text/x-patch (or at least text/plain) and a charset of UTF-8 or
> US-ASCII; if it contains binary data or mixed encoding it may need to
> specify a Content-Type of application/octet-stream instead. Please
> use an attachment file name that ends in ".diff" or ".patch" (or at
> least ".txt").
>
+1.
c.