This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Polished patch (crash after pthread_exit)
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 25 Jun 2013 11:16:04 -0400
- Subject: Re: [PATCH] Polished patch (crash after pthread_exit)
- References: <CAKt5dD1-XUyCSdhys+J5NJbCYQTMunwpcmECvRm1F0VSR4Jh+w at mail dot gmail dot com> <51C89EEB dot 3030604 at suse dot com> <51C8B629 dot 5090206 at redhat dot com> <20130624214304 dot EC63D2C09B at topped-with-meat dot com>
On 06/24/2013 05:43 PM, Roland McGrath wrote:
>> The reproducer which previous failed now passes.
>
> Then why isn't it in the test suite?
I had forgotten it. Are you opposed to me starting a new
set of nptl tests called `tst-pthreadX-static.c' which tracks
all of the sensible static things you might want to do with
libpthread.a?
Although there are lots of permutations of these functions
there are probably only a few useful orderings we need to
check to make libpthread.a work correctly (without having
to resort to something like Fedora's linking of the entire
library into one .o file).
Unless you think that Fedora's large static .o file is
perhaps a more maintainable solution? I'd rather we try
to keep the bloat down if at all possible.
Comments?
Cheers,
Carlos.