This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Avoid spurious failures from <fenv.h> fallback functions
- From: Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>
- To: thomas at codesourcery dot com
- Cc: libc-alpha at sourceware dot org, joseph at codesourcery dot com
- Date: Fri, 21 Jun 2013 18:04:32 +0900 (JST)
- Subject: Re: Avoid spurious failures from <fenv.h> fallback functions
- References: <Pine dot LNX dot 4 dot 64 dot 1306201045120 dot 4098 at digraph dot polyomino dot org dot uk> <20130621 dot 084619 dot 280715467 dot kkojima at rr dot iij4u dot or dot jp> <87sj0ckk8d dot fsf at schwinge dot name>
Thomas Schwinge <thomas@codesourcery.com> wrote:
> On Fri, 21 Jun 2013 08:46:19 +0900, Kaz Kojima <kkojima@rr.iij4u.or.jp> wrote:
>> "Joseph S. Myers" <joseph@codesourcery.com> wrote:
>>> Kaz, Thomas, note that there is no SH version of fgetexcptflg.c. This
>>> looks like an oversight, given that all the other <fenv.h> functions
>>> have SH implementations. Neither old nor new stub version would
>>> really be correct for SH; there should be a real implementation.
>>> Filed as bug 15655.
>>
>> It's really an oversight. I'd like to commit the attached patch
>> if it's OK to Thomas.
>
>> 2013-06-21 Kaz Kojima <kkojima@rr.iij4u.or.jp>
>>
> [BZ #15655]
>> * sysdeps/sh/sh4/fpu/fgetexcptflg.c: New file.
[snip]
> That three-line comment makes me think this is a copy of the MIPS sysdeps
> file; but yes, the implementation looks good to me.
Thanks for your comment! I'll commit it with adding bugzilla
line to the ChangeLog entry.
Regards,
kaz