This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 4/5][v2][BZ #15022] Extra dlopen/getpagesize static executable tests
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "Maciej W. Rozycki" <macro at codesourcery dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Wed, 19 Jun 2013 17:05:49 -0700 (PDT)
- Subject: Re: [PATCH 4/5][v2][BZ #15022] Extra dlopen/getpagesize static executable tests
- References: <alpine dot DEB dot 1 dot 10 dot 1301152056590 dot 4834 at tp dot orcam dot me dot uk> <20130116215545 dot 7A37A2C0B0 at topped-with-meat dot com> <alpine dot DEB dot 1 dot 10 dot 1301240655220 dot 4834 at tp dot orcam dot me dot uk> <20130531200059 dot C94C02C077 at topped-with-meat dot com> <alpine dot DEB dot 1 dot 10 dot 1306140202520 dot 16287 at tp dot orcam dot me dot uk>
> So here are the extra dlopen/getpagesize tests. They run successfully
> for the mips-linux target. As with the other dlopen tests I have added
> extra commentary per your request. Please let me know if you think this
> change should refer to BZ #15022. OK to apply?
If the test fails before the 15022 fix and passes after it, then it makes
sense to use the marker.
> + /* Try to map a module into the global scope. */
> + handle = dlopen ("modstatic5.so", RTLD_LAZY | RTLD_GLOBAL);
I don't understand why this is using RTLD_GLOBAL.
That does not seem to be material to this test.
> +/* GLRO (dl_pagesize) initialization DSO tests with a static executable.
(Incidentally, we write GLRO(dl_pagesize) with no space. It's a special
case.) This line and the large comment below are the same for the two
cases. tststatic5 already tests that. So this must be testing different
things that need to be tested, or else there is no point in the second test.
Its comments should say what exactly it is testing.
Thanks,
Roland