This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Set/restore rounding mode only when needed
- From: Siddhesh Poyarekar <siddhesh at redhat dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: Andreas Jaeger <aj at suse dot com>, libc-alpha at sourceware dot org, Josef Reidinger <jreidinger at suse dot cz>
- Date: Wed, 12 Jun 2013 09:55:30 +0530
- Subject: Re: [PATCH] Set/restore rounding mode only when needed
- References: <20130605110719 dot GU13968 at spoyarek dot pnq dot redhat dot com> <51B6D0E0 dot 6070707 at suse dot com> <Pine dot LNX dot 4 dot 64 dot 1306112156380 dot 897 at digraph dot polyomino dot org dot uk>
On Tue, Jun 11, 2013 at 10:01:47PM +0000, Joseph S. Myers wrote:
> This patch is OK with me. I do wonder if it's possible to reduce the
> number of macros and functions by always defining the rm_ctx type, as a
> struct just containing fenv_t when the architecture doesn't have any
> special tracking of updated_status, so that you don't need separate *_ctx
> macros and functions and everything using libc_fe* and related functions
> and macros just uses the rm_ctx type instead of using fenv_t directly.
> As far as I can see, updated_status is only used in the
> architecture-specific header for i386.
It might be possible to do something like this to reduce the number of
macros, but it will end up touching a lot of code. I could do that as
a cleanup in 2.19. I'll push this patch as is for now.
Thanks,
Siddhesh