This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] [BZ 15553]


On 05/30/2013 04:39 PM, Patsy Franklin wrote:
> 
> Carlos,
> 
> Thanks for the quick response.
> 
> -Patsy
> 
> v1
> - original
> v2
> - added reference to BZ
> 
> 2013-05-30  Patsy Franklin  <pfrankli@redhat.com>
> 
>     [BZ # 15553]        
>     * nis/yp_xdr.c (XDRMAXNAME): Define.
>     (XDRMAXRECORD): Define.
>     (xdr_domainname): Use XDRMAXNAME.
>     (xdr_mapname): Likewise.
>     (xdr_peername): Likewise.
>     (xdr_keydat): Use XDRMAXRECORD.
>     (xdr_valdat): Likewise.

This looks good to me.

The size of 16MB for a xdr request is big enough 
even for a really big NIS group.

Someone could still make a group large enough to break
this, but this patch is a good step towards preventing
that from happening while still limiting the DoS potential.

Please check this in, and make sure to follow:
http://sourceware.org/glibc/wiki/Committer%20checklist

Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]