This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] [BZ 15553]
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: pfrankli at redhat dot com
- Cc: libc-alpha at sourceware dot org, "Carlos O'Donell" <codonell at redhat dot com>
- Date: Thu, 30 May 2013 16:57:51 -0400
- Subject: Re: [PATCH v2] [BZ 15553]
- References: <51A7B905 dot 5000501 at redhat dot com>
On 05/30/2013 04:39 PM, Patsy Franklin wrote:
>
> Carlos,
>
> Thanks for the quick response.
>
> -Patsy
>
> v1
> - original
> v2
> - added reference to BZ
>
> 2013-05-30 Patsy Franklin <pfrankli@redhat.com>
>
> [BZ # 15553]
> * nis/yp_xdr.c (XDRMAXNAME): Define.
> (XDRMAXRECORD): Define.
> (xdr_domainname): Use XDRMAXNAME.
> (xdr_mapname): Likewise.
> (xdr_peername): Likewise.
> (xdr_keydat): Use XDRMAXRECORD.
> (xdr_valdat): Likewise.
This looks good to me.
The size of 16MB for a xdr request is big enough
even for a really big NIS group.
Someone could still make a group large enough to break
this, but this patch is a good step towards preventing
that from happening while still limiting the DoS potential.
Please check this in, and make sure to follow:
http://sourceware.org/glibc/wiki/Committer%20checklist
Cheers,
Carlos.