This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] [BZ #10283] localedef: align fixed maps to SHMLBA
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: Roland McGrath <roland at hack dot frob dot com>, David Miller <davem at davemloft dot net>, vapier at gentoo dot org, libc-alpha at sourceware dot org
- Date: Wed, 29 May 2013 09:01:24 -0400
- Subject: Re: [PATCH v2] [BZ #10283] localedef: align fixed maps to SHMLBA
- References: <20130528194042 dot 1EF7B2C074 at topped-with-meat dot com> <20130528 dot 130721 dot 1721261559877509450 dot davem at davemloft dot net> <51A51186 dot 7070904 at redhat dot com> <20130528 dot 132601 dot 2200516495498570890 dot davem at davemloft dot net> <51A524FE dot 7040202 at redhat dot com> <20130528231403 dot 2C6C32C05D at topped-with-meat dot com> <51A544A5 dot 5050001 at redhat dot com> <mvmli6ymdnx dot fsf at hawking dot suse dot de>
On 05/29/2013 03:46 AM, Andreas Schwab wrote:
> "Carlos O'Donell" <carlos@redhat.com> writes:
>
>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/mmap.html
>> ~~~
>> If MAP_FIXED is specified, the implementation may
>> require that addr is a multiple of the page size.
>> ~~~
>> Thus addr must be aligned to N*<page size>, where N is implementation
>> specific.
>
> That does not follow from here. The important bits are here:
>
> The mmap() function may fail if:
> [EINVAL]
> The addr argument (if MAP_FIXED was specified) or off is not a
> multiple of the page size as returned by sysconf(), or is considered
> ^^^^^^^^^^
> invalid by the implementation.
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Are you saying that the definition of the error implies
that *any* value is allowed for addr and may be at any
time rejected by the implementation?
Cheers,
Carlos.