This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Link extra-libs consistently with libc and ld.so
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: <libc-alpha at sourceware dot org>, <libc-ports at sourceware dot org>
- Date: Tue, 28 May 2013 16:58:46 -0700 (PDT)
- Subject: Re: Link extra-libs consistently with libc and ld.so
- References: <Pine dot LNX dot 4 dot 64 dot 1305090021040 dot 25137 at digraph dot polyomino dot org dot uk> <Pine dot LNX dot 4 dot 64 dot 1305140032090 dot 10338 at digraph dot polyomino dot org dot uk> <20130517202428 dot B17DA2C0BE at topped-with-meat dot com> <Pine dot LNX dot 4 dot 64 dot 1305172317400 dot 22690 at digraph dot polyomino dot org dot uk>
> 2013-05-17 Joseph Myers <joseph@codesourcery.com>
>
> * Makefile ($(common-objpfx)linkobj/libc.so): Define
> link-libc-deps to empty as target-specific variable.
> * Makerules (link-libc-args): New variable.
> (libc-for-link): Likewise.
> (link-libc-deps): Likewise.
> (lib%.so): Depend in $(link-libc-deps). Link with
> $(link-libc-args).
s/in/on/
> +# Target-specific variable setting:
> +$(services:%=$(objpfx)libnss_%.so) $(objpfx)libnsl.so: \
> + libc-for-link = $(libnsl-libc)
Use two-space indentation for this case.
Otherwise it looks too similar to a target with commands.
The comment should say why it's there, not just what it is.
(The commentary was inadequate before, but this is a good time to improve it.)
> +# Target-specific variable setting:
> +$(services:%=$(objpfx)libnss_%.so): libc-for-link = $(libnss-libc)
Likewise with this comment.
Aside from those tiny cosmetic issues, this looks fine to me.
Thanks,
Roland