This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Minor doc patch: arith.texi
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Ben North <ben at redfrontdoor dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 22 May 2013 23:46:16 -0400
- Subject: Re: Minor doc patch: arith.texi
- References: <CAHG0eJWK+AGYLJb=6rk7b8C2u7K1CSqupj0OTju4b7h6w37Pnw at mail dot gmail dot com> <519D8F9D dot 1030700 at redhat dot com>
On 05/22/2013 11:40 PM, Carlos O'Donell wrote:
> On 05/21/2013 02:29 PM, Ben North wrote:
>> Hi,
>>
>> The attached patch fixes a slight inaccuracy in the documentation for
>> 'frexp'. The current documentation does not correctly describe the
>> behaviour when frexp is given a negative value. E.g.,
>>
>> frexp(-11.875, &exponent)
>>
>> returns -0.7421875, which is not "in the range 1/2 (inclusive) to 1
>> (exclusive)" as the info page says. The patch inserts "its absolute
>> value".
>
> Thanks for posting this fix!
>
> For full information about posting a patch see:
> http://sourceware.org/glibc/wiki/Contribution%20checklist
>
> Your patch is so small you can skip a lot of steps.
>
> You don't need a bugzilla entry.
>
> It's small enough that you don't need copyright assignment, but
> if you plan to contribute more you will.
>
>> diff -Naur orig/arith.texi patched/arith.texi
>> --- orig/arith.texi 2013-05-21 18:26:51.246430215 +0100
>> +++ patched/arith.texi 2013-05-21 18:28:41.515049617 +0100
>> @@ -1221,7 +1221,7 @@
>> into a normalized fraction and an exponent.
>>
>> If the argument @var{value} is not zero, the return value is @var{value}
>> -times a power of two, and is always in the range 1/2 (inclusive) to 1
>> +times a power of two, and its absolute value is always in the range 1/2 (inclusive) to 1
>
> Rewrite using "manitude" please and as succinctly as possible.
s/manitude/magnitude/g
Sorry.
>
>> (exclusive). The corresponding exponent is stored in
>> @code{*@var{exponent}}; the return value multiplied by 2 raised to this
>> exponent equals the original number @var{value}.
>
> Repost with changes and a ChangeLog entry please (lets me know
> what email to use for attribution in git).
>
> Cheers,
> Carlos.
>