This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Test getaddrinfo return value
- From: Siddhesh Poyarekar <siddhesh dot poyarekar at gmail dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: "Dmitry V. Levin" <ldv at altlinux dot org>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Sat, 18 May 2013 08:08:11 +0530
- Subject: Re: [PATCH v2] Test getaddrinfo return value
- References: <20130430054726 dot GN1330 at spoyarek dot pnq dot redhat dot com> <20130507102602 dot GE5741 at spoyarek dot pnq dot redhat dot com> <20130510061441 dot GK19683 at spoyarek dot pnq dot redhat dot com> <20130513074609 dot GF25336 at spoyarek dot pnq dot redhat dot com> <20130516033932 dot GA28292 at spoyarek dot pnq dot redhat dot com> <20130516232604 dot GA3090 at altlinux dot org> <20130517052735 dot GD16952 at spoyarek dot pnq dot redhat dot com> <20130517053716 dot GF16952 at spoyarek dot pnq dot redhat dot com> <20130517221514 dot GA10035 at altlinux dot org> <20130517222311 dot BE8352C0C4 at topped-with-meat dot com> <20130517225710 dot GA10326 at altlinux dot org> <20130517231152 dot A09262C0C7 at topped-with-meat dot com>
On 18 May 2013 04:41, Roland McGrath <roland@hack.frob.com> wrote:
>> This helps testing for regression of BZ#15339.
>
> Then the log entry should start with a line:
> [BZ #15339]
>
>> +++ b/posix/tst-getaddrinfo4.c
>> @@ -0,0 +1,67 @@
>> +/* Test getaddrinfo return value.
>
> Point to the BZ# here too.
>
> With those nits, and if this test currently passes, then this looks fine.
>
The test should pass in normal conditions (network available or down
but lo configured). It would fail when there is no networking support
due to bug 15339. The fix for it is in the following post, which
needs an additional review:
http://sourceware.org/ml/libc-alpha/2013-05/msg00567.html
Siddhesh
--
http://siddhesh.in