This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH rsa/power8] PowerPC: Add support for POWER8.
- From: "Ryan S. Arnold" <ryan dot arnold at gmail dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: "Ryan S. Arnold" <rsa at us dot ibm dot com>, libc-alpha <libc-alpha at sourceware dot org>
- Date: Fri, 17 May 2013 14:08:30 -0500
- Subject: Re: [PATCH rsa/power8] PowerPC: Add support for POWER8.
- References: <1368725852 dot 6842 dot 11 dot camel at localhost dot localdomain> <20130516235801 dot DFFE42C084 at topped-with-meat dot com>
On Thu, May 16, 2013 at 6:58 PM, Roland McGrath <roland@hack.frob.com> wrote:
>> -/* There are 25 bits used in AT_HWCAP, but they are bits 7..31. */
>> +/* There are 25 bits used in AT_HWCAP, but they are bits 7..31. The feature
>> + * definitions started at bit 31 and decremented as new features were added.
>> + */
>> +#define _DL_HWCAP_LAST 31
>
> Comment style.
>
>> +/* AT_HWCAP2 feature bits similarily started at bit 31 and decremented as new
>> + * features were added. */
>> +#define _DL_HWCAP2_LAST 31
>
> Here too.
>
> Nothing else popped out at me and this is all in powerpc directories, so
> it's your call to declare it tested enough.
Thanks,
I'll fix the comments.
I won't presume that this is an ack on the AT_HWCAP2 and
powerpc/dl-procinfo patches though I think I've met your requests for
both. So POWER8 support is blocked on these patches.
Ryan