This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 4/5] Use movq for 64-bit operations
- From: Peter Collingbourne <pcc at google dot com>
- To: Richard Henderson <rth at twiddle dot net>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 14 May 2013 18:29:50 +0200
- Subject: Re: [PATCH 4/5] Use movq for 64-bit operations
- References: <1368459372-2415-1-git-send-email-pcc at google dot com> <1368459372-2415-5-git-send-email-pcc at google dot com> <5191142C dot 7070101 at twiddle dot net>
On Mon, May 13, 2013 at 6:26 PM, Richard Henderson <rth@twiddle.net> wrote:
> On 05/13/2013 08:36 AM, Peter Collingbourne wrote:
>> The EXTRACT_WORDS64 and INSERT_WORDS64 macros use movd for a 64-bit
>> operation. Somehow gcc manages to turn this into movq, but LLVM won't.
>>
>> 2013-05-13 Peter Collingbourne <pcc@google.com>
>>
>> * sysdeps/x86_64/fpu/math_private.h (MOVQ): New macro.
>> (EXTRACT_WORDS64) Use where appropriate.
>> (INSERT_WORDS64) Likewise.
>
> There's a compatibility issue with older gas where movq wasn't accepted,
> but movd was. Current gas allows either. There should be an investigation
> as to what gas version contains the fix, and if its older than the minimum
> required binutils version.
I successfully built glibc with 2.20 in $PATH with my changes applied. (Also,
we're already using movq in plenty of places elsewhere in glibc.)
Peter