This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PING][PATCH][BZ #15022] Correct global-scope dlopen issues in static executables
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: "Maciej W. Rozycki" <macro at codesourcery dot com>
- Cc: Roland McGrath <roland at hack dot frob dot com>, libc-alpha at sourceware dot org
- Date: Tue, 14 May 2013 00:44:37 -0400
- Subject: Re: [PING][PATCH][BZ #15022] Correct global-scope dlopen issues in static executables
- References: <alpine dot DEB dot 1 dot 10 dot 1301152056590 dot 4834 at tp dot orcam dot me dot uk> <20130116215545 dot 7A37A2C0B0 at topped-with-meat dot com> <alpine dot DEB dot 1 dot 10 dot 1301240655220 dot 4834 at tp dot orcam dot me dot uk> <alpine dot DEB dot 1 dot 10 dot 1305140020480 dot 26443 at tp dot orcam dot me dot uk>
On 05/13/2013 07:25 PM, Maciej W. Rozycki wrote:
>
> Ping. I'd appreciate if this fix made it to 2.18, can you please review
> the updated patch I posted here:
> <http://sourceware.org/ml/libc-alpha/2013-01/msg00887.html>?
I've reviewed your code, and your new test cases and they look
good to me.
Roland's comment about preserving user-visible semantics doesn't
seem to apply in this case. This case has never worked as far as
I can tell which means there are no directly user-visible semantics
to preserve. I would say your patch is a big step forwards to
preserving the user-visible semantics from the dynamic application
and ensuring that the static application mostly behaves in the
same way. It is completely acceptable IMO that the global scope
should be empty for a static executable and that dlsym() should
return appropriate errors.
The additional tststatic5 and tststatic6 tests are exactly the tests
that I would have wanted; they are minimal and express the behaviour
that we expect from the API without involving anything overly
complicated.
Thanks for the detailed problem description, and thorough analysis.
It's always a pleasure to review your patches.
I'm OK with version 2 going into 2.18.
Cheers,
Carlos.