This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[COMMITTED] Remove eval from bench target
- From: Siddhesh Poyarekar <siddhesh at redhat dot com>
- To: Tulio Magno Quites Machado Filho <tuliom at linux dot vnet dot ibm dot com>
- Cc: "Carlos O'Donell" <carlos at redhat dot com>, Roland McGrath <roland at hack dot frob dot com>, libc-alpha at sourceware dot org
- Date: Thu, 11 Apr 2013 09:19:01 +0530
- Subject: [COMMITTED] Remove eval from bench target
- References: <20130403080526 dot GA20842 at spoyarek dot pnq dot redhat dot com> <20130408220956 dot 124492C09F at topped-with-meat dot com> <20130409044525 dot GD15689 at spoyarek dot pnq dot redhat dot com> <516419D3 dot 1070007 at redhat dot com> <20130409134404 dot GM15689 at spoyarek dot pnq dot redhat dot com> <5164996A dot 1020809 at redhat dot com> <20130410050136 dot GV15689 at spoyarek dot pnq dot redhat dot com> <87r4iif70w dot fsf at totoro dot br dot ibm dot com> <87r4ihq40l dot fsf at linux dot vnet dot ibm dot com>
On Wed, Apr 10, 2013 at 09:56:10PM -0300, Tulio Magno Quites Machado Filho wrote:
>
> Siddhesh, feel free to remove this eval.
>
OK thanks. I've pushed this as obvious/pre-approved.
Siddhesh
commit 8da491f585f6112630688d0632407f5460136ffe
Author: Siddhesh Poyarekar <siddhesh@redhat.com>
Date: Thu Apr 11 09:15:52 2013 +0530
Remove eval
It's not needed.
diff --git a/ChangeLog b/ChangeLog
index 4115225..5d8b297 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2013-04-11 Siddhesh Poyarekar <siddhesh@redhat.com>
+
+ * Rules (bench): Remove eval.
+
2013-04-10 Siddhesh Poyarekar <siddhesh@redhat.com>
Roland McGrath <roland@hack.frob.com>
Ondrej Bilka <neleai@seznam.cz>
diff --git a/Rules b/Rules
index d4a0027..e8e1117 100644
--- a/Rules
+++ b/Rules
@@ -199,7 +199,7 @@ run-bench = $(test-wrapper-env) \
bench: $(binaries-bench)
for run in $^; do \
echo "Running $${run}"; \
- eval $(run-bench) >> $(objpfx)bench.out-tmp; \
+ $(run-bench) >> $(objpfx)bench.out-tmp; \
done; \
if [ -f $(objpfx)bench.out ]; then \
mv -f $(objpfx)bench.out $(objpfx)bench.out.old; \