This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Rename some static variables in nptl for readability
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 15 Mar 2013 10:40:26 -0400
- Subject: Re: [PATCH] Rename some static variables in nptl for readability
- References: <20130315102538.GA671@spoyarek.pnq.redhat.com>
On 03/15/2013 06:25 AM, Siddhesh Poyarekar wrote:
> Hi,
>
> These bits were part of my initial patch to set things up for default
> thread attributes patch, but Roland suggested that I break them up
> since they're an unrelated cleanup (the were related earlier since
> their names clashed with the default_attr I intended to share across
> the library, but I'm calling that variable __default_attr now). So
> here it is - the patch renames some static variables in nptl so that
> they have unique names. Does not cause any regressions in the
> testsuite. OK to commit?
>
> Siddhesh
>
> * pthread_barrier_init.c (default_attr): Rename to
> default_barrierattr.
> (pthread_barrier_init): Adjust for the rename.
> * pthread_mutex_init.c (default_attr): Rename to
> default_mutexattr.
> (__pthread_mutex_init): Adjust for the rename.
> * pthread_rwlock_init.c (default_attr): Rebane to
> default_rwlockattr.
> (__pthread_rwlock_init): Adjust for the rename.
This looks good to me.
I like it when we name variables with names that make sense.
If you get no objections I'd check it in on Monday.
Cheers,
Carlos.