Re: [PATCH] Promote a math test for sNaN handling to the top-level.

[Thomas Schwinge <thomas at codesourcery dot com>]

Hi!

On Tue, 5 Mar 2013 23:29:32 +0000, "Joseph S. Myers" <joseph@codesourcery.com> wrote:
> On Tue, 5 Mar 2013, Thomas Schwinge wrote:
> 
> > Tested on x86 and x86_64 GNU/Linux natively, and cross-tested for MIPS32
> > O32 GNU/Linux.
> > 
> > 	* sysdeps/powerpc/fpu/test-powerpc-snan.c: Rename to
> > 	math/test-snan.c.
> > 	* math/test-snan.c: Renamed from
> > 	sysdeps/powerpc/fpu/test-powerpc-snan.c.
> > 	* math/Makefile (tests): Add test-snan.
> > 	* sysdeps/powerpc/fpu/Makefile (libm-tests): Don't add
> > 	test-powerpc-snan.
> 
> This test is not portable.  init_signaling_nan hard-codes bit-patterns, 
> including for IBM long double, and those patterns also embed a big-endian 
> assumption as well as floating-point format assumptions.  Thus, it should 
> not be treated as generic as-is.  The sNaNs need initializing portably 
> instead, using the appropriate GCC built-in functions.

That I think I all fixed in the earlier
<http://news.gmane.org/find-root.php?message_id=%3C1362512104-27910-1-git-send-email-thomas%40codesourcery.com%3E>.
Sorry for not better pointing out this inter-patch dependency, and please
speak up (in that thread) if you see any issues with this approach.


GrÃÃe,
 Thomas

Attachment: pgp00000.pgp
Description: PGP signature