This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Ping: [PATCH] Add inline bsearch expansion


On Wed, Feb 13, 2013 at 12:12:24PM +0000, Marcus Shawcroft wrote:
> > 2013-02-09   OndÅej BÃlka  <neleai@seznam.cz>
> >
> >         * bits/stdlib-bsearch.h: New file.
> >         * stdlib/bsearch.c: Include bits/stdlib-bsearch.h.
> >         * stdlib/stdlib.h(bsearch): Add inline bsearch.
> >
> 
> 
> Hi,  This change appears to be responsible for a build error I see
> libgomp (see below).  I suspect the issue is that the new file
> bits/stdlib-bsearch.h is not being installed because it does not
> appear in stdlib/Makefile headers ?
> 
> Cheers
> /Marcus
> 
> 
> ===
> 
> In file included from /foo/src/gcc/libgomp/error.c:35:0:
> /foo/workdir/rhe5x86_64/arm-none-linux-gnueabi/install/opt/aarch32/arm-none-linux-gnueabi/libc/usr/include/stdlib.h:760:34:
> fatal error: bits/stdlib-bsearch.h: No such file or directory
>  # include <bits/stdlib-bsearch.h>
>                                   ^
> compilation terminated.

Yes, I was not aware it is neccesary to add it into Makefile. 

Commited this as obvious fix, tested that make install-header creates
it.

 2013-02-13   OndÅej BÃlka  <neleai@seznam.cz>
 
	* stdlib/Makefile: Install stdlib-bsearch.h header.

diff --git a/stdlib/Makefile b/stdlib/Makefile
index 4bfd4b9..e2078f8 100644
--- a/stdlib/Makefile
+++ b/stdlib/Makefile
@@ -25,7 +25,8 @@ headers	:= stdlib.h bits/stdlib.h bits/stdlib-ldbl.h bits/stdlib-float.h      \
 	   inttypes.h stdint.h bits/wordsize.h				      \
 	   errno.h sys/errno.h bits/errno.h				      \
 	   ucontext.h sys/ucontext.h					      \
-	   alloca.h fmtmsg.h
+	   alloca.h fmtmsg.h						      \
+	   bits/stdlib-bsearch.h
 
 routines	:=							      \
 	atof atoi atol atoll						      \
-- 
1.7.4.4


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]