This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] avoid stat/fstat in statvfs/fstatvfs
That looks fine.
> * sysdeps/unix/sysv/linux/fstatvfs.c (fstatvfs):
> Pass fd to __internal_statvfs instead of calling fstat64.
> * sysdeps/unix/sysv/linux/fstatvfs64.c (__fstatvfs64):
> Pass fd to __internal_statvfs64 instead of calling fstat64.
In a case like this, it's usual practice to write just "Likewise."
for the second one. But that's not mandatory.
Ideally there should be a bugzilla item filed for this issue.
Even though it's not really user-visible per se (for user-visible changes
we have a hard rule requiring bugzilla filings), a change that is being
tracked by downstream bug reports and such is easier for everyone to
keep track of if there is a BZ# to go with it. If you file one,
use [BZ #nnn] in the log entry as you see done elsewhere in ChangeLog.
Do you have copyright papers on file with the FSF? I don't see a record
for you.
Do you want someone to commit this for you? If you think it likely you'll
post more changes in the future, then we encourage you to get set up to do
your own commits (on specific approval, of course). The details are on
the wiki.
Thanks,
Roland