This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: ping: [patch] Fix l_addr comment
On Fri, 01 Feb 2013 19:01:37 +0100, Roland McGrath wrote:
> How about just:
>
> Difference between the address in the ELF file and the addresses in memory.
It is no longer wrong and hopefully clear enough.
(BTW I would say s/addresses in memory/address in memory/.)
I can take the authorship if you want.
OK for check-in? (I do not remember if I can.)
Thanks,
Jan
2013-02-01 Roland McGrath <roland@hack.frob.com>
* elf/link.h (struct link_map): Extend the l_addr comment.
* include/link.h (struct link_map): Likewise.
diff --git a/elf/link.h b/elf/link.h
index 500871f..a50ba83 100644
--- a/elf/link.h
+++ b/elf/link.h
@@ -86,7 +86,8 @@ struct link_map
/* These first few members are part of the protocol with the debugger.
This is the same format used in SVR4. */
- ElfW(Addr) l_addr; /* Base address shared object is loaded at. */
+ ElfW(Addr) l_addr; /* Difference between the address in the ELF
+ file and the addresses in memory. */
char *l_name; /* Absolute file name object was found in. */
ElfW(Dyn) *l_ld; /* Dynamic section of the shared object. */
struct link_map *l_next, *l_prev; /* Chain of loaded objects. */
diff --git a/include/link.h b/include/link.h
index 12dcf03..230e95d 100644
--- a/include/link.h
+++ b/include/link.h
@@ -87,7 +87,8 @@ struct link_map
/* These first few members are part of the protocol with the debugger.
This is the same format used in SVR4. */
- ElfW(Addr) l_addr; /* Base address shared object is loaded at. */
+ ElfW(Addr) l_addr; /* Difference between the address in the ELF
+ file and the addresses in memory. */
char *l_name; /* Absolute file name object was found in. */
ElfW(Dyn) *l_ld; /* Dynamic section of the shared object. */
struct link_map *l_next, *l_prev; /* Chain of loaded objects. */