This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] refactor strspn/strcspn macro
- From: Roland McGrath <roland at hack dot frob dot com>
- To: OndÅej BÃlka <neleai at seznam dot cz>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 16 Jan 2013 14:30:03 -0800 (PST)
- Subject: Re: [PATCH] refactor strspn/strcspn macro
- References: <20130116125813.GB16869@domone.kolej.mff.cuni.cz>
Use a less opaque name, e.g. __maybe_builtin_strcspn.
Your log entry lacks appropriate whitespace, punctuation, and detail.
A good entry for just the strcspn part looks like:
* string/bits/string2.h [!_HAVE_STRING_ARCH_strcspn || _FORCE_INLINES]
[!_HAVE_STRING_ARCH_strcspn] (__maybe_builtin_strcspn): New macro,
defined differently under [__GNUC_PREREQ (3, 2)] and not.
[!_HAVE_STRING_ARCH_strcspn] (strcspn): Consolidate variant
definitions into one that calls __maybe_builtin_strcspn.