Re: [PATCH] Correct global-scope dlopen issues in static executables

[Roland McGrath <roland at hack dot frob dot com>]

As Joseph said, you should file two bugs with appropriate minimal test
cases for the two issues.  Then use [BZ #nnn] in the log entry for the
change that affects the bug.

I would like to see a fix that does not change user-visible semantics at
all (aside from not crashing, of course).  If the change to the
user-visible semantics of dlopen is desireable, then propose it
separately.  If it's inordinately difficult or ugly to fix the crash
without the semantic change, then let the semantic change go in and
settle first.  If it's reasonably doable to fix the problems without the
semantic change, then send the fixes first and then if the semantic
change is desireable and goes in later, you can send additional cleanup
changes to make the code simpler again afterwards.

Each test case should be minimal and focussed on testing just one thing.
For dynamic linking tests, that means they should use pure examples that
only rely on linking behavior use trivial functions in the test itself.
If it's worthwhile to test something having to do with the value
returned by getpagesize, add that as separate test for getpagesize or
whatever it is truly testing, not for linking behavior.


Thanks,
Roland