This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Don't check __GNUC__ together with __USE_EXTERN_INLINES


On Tue, Jan 08, 2013 at 04:01:15PM +0000, Joseph S. Myers wrote:
> On Tue, 8 Jan 2013, Siddhesh Poyarekar wrote:
> 
> > There are a couple of places where __USE_EXTERN_INLINES is explicitly
> > set, for example in argp/argp-xinl.h.  The patch could break such code
> > if it includes any of the headers you've changed after explcitly
> > setting __USE_EXTERN_INLINES.  If you've verified that these cases
> > don't break then the change should be safe.
> 
> The purpose of those places is to provide out-of-line versions of the 
> inline functions from one specific header that is included after the 
> definition of __USE_EXTERN_INLINES.  Thus those places already require 
> extern inline functions in fact to be supported and would fail to build if 
> using a compiler not supporting them.
> 

Looks fine then.

Thanks,
Siddhesh


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]