This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [Patch] [BZ 13761] Fix another unbound alloca
From: Jeff Law <law@redhat.com>
Date: Thu, 29 Nov 2012 00:29:23 -0700
> On 11/29/2012 12:05 AM, Andreas Jaeger wrote:
>> On 11/28/2012 11:12 PM, Jeff Law wrote:
>>> To recap (from the BZ):
>>>
>>> nss_compat allocates buffer space on stack using alloca (and
>>> extend_alloca) for initgroup and keeps extending it to fit in larger
>>> lines. This breaks for cases where the number of members in a gorup
>>> are very large, causing the alloca reference to go beyond thread stack
>>> boundary. Siddhesh partially fixed this problem a while back, this
>>> patch completes the fix.
>>
>> This looks fine to me,
> Thanks. David's call as to whether or not to pull this into 2.17;
> barring an explicit OK from him I'll hold off installing until after
> the tree is unfrozen.
I'm fine with this going in, please commit it.