This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Resolve buffer overflow in libm-test-inc check_complex()

From: "Joseph S. Myers" <joseph at codesourcery dot com>
To: Marcus Shawcroft <marcus dot shawcroft at linaro dot org>
Cc: GNU C Library <libc-alpha at sourceware dot org>
Date: Thu, 15 Nov 2012 16:47:40 +0000
Subject: Re: [PATCH] Resolve buffer overflow in libm-test-inc check_complex()
References: <CABXK9ndZtRHT2iOK1_CX25i6+bqm5sie3G-DL3aM8JKB8KqyAA@mail.gmail.com><Pine.LNX.4.64.1211142310090.19042@digraph.polyomino.org.uk><CABXK9ne5+i0Yh55nX7M3k_vhWbwtAn0e35fUewZJz=8sTFmzyA@mail.gmail.com>

On Thu, 15 Nov 2012, Marcus Shawcroft wrote:

> On 14 November 2012 23:11, Joseph S. Myers <joseph@codesourcery.com> wrote:
> 
> > When using asprintf, please check the return value and produce an
> > appropriate error if it is -1 (maybe just abort the test, in this case).
> > (If the return value is -1, the value of the pointer asprintf sets is
> > undefined, so you do need to check the return value before using that
> > pointer.)
> 
> 
> Revised version attached.

This version is OK.

-- 
Joseph S. Myers
joseph@codesourcery.com

References:
- [PATCH] Resolve buffer overflow in libm-test-inc check_complex()
  - From: Marcus Shawcroft
- Re: [PATCH] Resolve buffer overflow in libm-test-inc check_complex()
  - From: Joseph S. Myers
- Re: [PATCH] Resolve buffer overflow in libm-test-inc check_complex()
  - From: Marcus Shawcroft

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]