This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] BZ #14831: Segfault in _dl_profile_fixup with IRELATIVEand LD_AUDIT
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 13 Nov 2012 16:26:27 -0800 (PST)
- Subject: Re: [PATCH] BZ #14831: Segfault in _dl_profile_fixup with IRELATIVEand LD_AUDIT
- References: <20121113223647.GA10300@gmail.com><20121114001759.GA23387@gmail.com>
> + if (l->l_reloc_result == NULL)
> + {
> + /* Skip audit if l_reloc_result is NULL which happens with
> + IRELATIVE relocations in other DSOs, like libm.so. */
> + *framesizep = -1;
This needs a more extensive comment about how it arises that we get here
with l_reloc_result NULL and why it is OK to short-circuit this way.
> + return _dl_fixup (l, reloc_arg);
How can this be right when ELF_MACHINE_RUNTIME_FIXUP_ARGS is nonempty?
Thanks,
Roland