This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Use unmodified tzselect.ksh in glibc
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Fri, 9 Nov 2012 14:55:23 -0800 (PST)
- Subject: Re: Use unmodified tzselect.ksh in glibc
- References: <Pine.LNX.4.64.1211092246150.25519@digraph.polyomino.org.uk>
> + sed -e 's|/bin/bash|$(KSH)|g' \
> + -e 's|TZDIR=\$$(pwd)|TZDIR=$(zonedir)|g' \
> + -e 's|see_Makefile|"$(PKGVERSION)$(version)"|g' < $< > $@.new
This is probably fine as is, but I'd be inclined to tighten it up a bit.
Things are not as we expect if (at least for the last two) if they might
match more than once, so drop "g". My inclination would be:
-e '/TZDIR=/s|\$$(pwd)|$(zonedir)|' \
-e '/TZVERSION=/s|see_Makefile|"$(PKGVERSION)$(version)"|' \
< $< > $@.new
And we usually use an extra continuation line like that when one or both
parts (here both) are likely to wind up much longer in the make output
than they are in the source.
Such nits aside, the change is good.
Thanks,
Roland