This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Support cross-testing (version 3)


"Joseph S. Myers" <joseph@codesourcery.com> writes:

> diff --git a/scripts/cross-test-ssh.sh b/scripts/cross-test-ssh.sh
> new file mode 100755
> index 0000000..f09c98e
> --- /dev/null
> +++ b/scripts/cross-test-ssh.sh
> @@ -0,0 +1,148 @@
> +#! /bin/bash

This script must not use bash.

> +# Unset all variables from the blacklist.  Then echo all exported
> +# variables.  The 'export -p' command adds backslashes for environment
> +# variables which contain newlines.
> +blacklist_exports ()
> +{
> +  (unset ${env_blacklist}; export -p) | remove_newlines

If called by bash, export -p outputs series of declare -x commands,
which will fail if the remote /bin/sh is not bash.

Andreas.

	* scripts/cross-test-ssh.sh: Use /bin/sh instead of /bin/bash.
	(bourne_quote): Remove use of local.
---
 scripts/cross-test-ssh.sh | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/scripts/cross-test-ssh.sh b/scripts/cross-test-ssh.sh
index f09c98e..32d9a39 100755
--- a/scripts/cross-test-ssh.sh
+++ b/scripts/cross-test-ssh.sh
@@ -1,4 +1,4 @@
-#! /bin/bash
+#! /bin/sh
 # Run a testcase on a remote system, via ssh.
 # Copyright (C) 2012 Free Software Foundation, Inc.
 # This file is part of the GNU C Library.
@@ -101,7 +101,6 @@ host="$1"; shift
 # Bourne shell, separated by spaces.
 bourne_quote ()
 {
-  local arg qarg
   for arg in "$@"; do
     qarg=${arg//\'/\'\\\'\'}
     echo -n "'$qarg' "
-- 
1.8.0


-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]