This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3] manual: fix up grammar
> But each message (unless equal to another one) must have its own unique
> -pair of set and message number.
> +pair of set and message numbers.
This change is wrong.
> -We see how the catalog object is opened and the returned descriptor used
> +We see how the catalog object is opened and the returned descriptor is used
> in the other function calls.
This change is OK but the grammar was acceptable unchanged.
I noticed several other changes that were not, stricly speaking, grammar or
spelling fixes, but just rewordings. Those may well be improvements, but
I don't think you should include them in a patch that is labelled as being
purely fixes for actual grammatical errors.
> @smallexample
> -@cartouche
> % gencat -H msgnrs.h -o hello.cat hello.msg
> % cat msgnrs.h
> #define MainSet 0x1 /* hello.msg:4 */
> @@ -711,10 +706,9 @@ de
> % ./hello
> Hallo, Welt!
> %
> -@end cartouche
> @end smallexample
A formatting change like this really has nothing whatsoever to do with
grammar. Again, perhaps it's desireable. But make it a separate change
and call it what it is.
> +While the paradigms underlying the @code{gettext} approach to message
> +translations are different from that of the @code{catgets} functions, the
> +basic functionally is equivalent.
either singular "paradigm" or "from those"
Thanks,
Roland