This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v3] change ifunc assembly test to a link test

From: Roland McGrath <roland at hack dot frob dot com>
To: Mike Frysinger <vapier at gentoo dot org>
Cc: libc-alpha at sourceware dot org
Date: Wed, 24 Oct 2012 11:21:29 -0700 (PDT)
Subject: Re: [PATCH v3] change ifunc assembly test to a link test
References: <1350964487-8087-1-git-send-email-vapier@gentoo.org><1351046207-20731-1-git-send-email-vapier@gentoo.org><20121024171235.534BE2C0A5@topped-with-meat.com><201210241350.56182.vapier@gentoo.org>

> > This is subject to false-negatives if there is some unexpected weirdness
> > with readelf or something.  But I'm not too concerned.
> 
> yeah, that's why i sent the full readelf output to the log to make it
> easy to diagnose in the future.  i checked x86_64/arm/ia64 to make sure
> it was OK.

That was a good thing to do, certainly.  But what I have in mind is where
the test yields "no" and the person doing the build doesn't notice it, but
just builds a less-optimal library.

References:
- [PATCH] change ifunc assembly test to a link test
  - From: Mike Frysinger
- [PATCH v3] change ifunc assembly test to a link test
  - From: Mike Frysinger
- Re: [PATCH v3] change ifunc assembly test to a link test
  - From: Roland McGrath
- Re: [PATCH v3] change ifunc assembly test to a link test
  - From: Mike Frysinger

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]