This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH siddhesh/wait_bitset] Use FUTEX_WAIT_BITSET forpthread_cond_timedwait for non-x86: ppc, s390
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 23 Oct 2012 17:00:39 -0700 (PDT)
- Subject: Re: [PATCH siddhesh/wait_bitset] Use FUTEX_WAIT_BITSET forpthread_cond_timedwait for non-x86: ppc, s390
- References: <20121022182330.4f774b71@spoyarek>
> * pthread_cond_timedwait.c (__pthread_cond_timedwait): Timeout
> if absolute timeout is negative.
When used as a verb, write "Time out".
> * sysdeps/unix/sysv/linux/powerpc/lowlevellock.h
> (lll_futex_timed_wait_bitset); Define.
> * sysdeps/unix/sysv/linux/s390/lowlevellock.h
> (lll_futex_timed_wait_bitset); Likewise.
s/;/:/. Say "New macro".
> +#if (!defined(__ASSUME_FUTEX_CLOCK_REALTIME) \
> + || !defined(lll_futex_timed_wait_bitset))
Space before paren, or omit the parens after 'defined' entirely.
They are superfluous here.
The substance of the change looks fine to me, but it needs powerpc and s390
folks to look at it.
Thanks,
Roland