This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Fix O_LARGEFILE for Linux/SPARC and s390 (was: Re: [PATCH] ARM:Use <bits/fcntl-linux.h> )
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Andreas Jaeger <aj at suse dot com>
- Cc: "libc-ports at sourceware dot org" <libc-ports at sourceware dot org>,<libc-alpha at sourceware dot org>
- Date: Mon, 22 Oct 2012 14:06:23 +0000
- Subject: Re: Fix O_LARGEFILE for Linux/SPARC and s390 (was: Re: [PATCH] ARM:Use <bits/fcntl-linux.h> )
- References: <5084483B.4030205@suse.com> <Pine.LNX.4.64.1210212250110.1291@digraph.polyomino.org.uk><Pine.LNX.4.64.1210212257280.1291@digraph.polyomino.org.uk> <2036625.SeAZvNclbu@byrd>
On Mon, 22 Oct 2012, Andreas Jaeger wrote:
> #ifdef __USE_LARGEFILE64
> # if __WORDSIZE == 64
> /* Not necessary, files are always with 64bit off_t. */
> -# define O_LARGEFILE 0
> +# define __O_LARGEFILE 0
> # else
> -# define O_LARGEFILE 0100000
> +# define __O_LARGEFILE 0100000
> # endif
> #endif
I think it's more consistent not to have the __USE_LARGEFILE64
conditionals here: to define the __O_* macro unconditionally (like other
__O_* macros) and have the conditional only in fcntl-linux.h on the
O_LARGEFILE definition.
--
Joseph S. Myers
joseph@codesourcery.com