This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][BZ #14694] Fix weekday and month names for mr_IN


On Mon, Oct 15, 2012 at 3:27 PM, Siddhesh Poyarekar <siddhesh@redhat.com> wrote:
> On Mon, 15 Oct 2012 12:39:12 -0600, Jeff wrote:
>> For abmon/mon, it looks to me like this patch changes August as well.
>> Correct?
>
> Oh yes it does; sorry I didn't notice that change.  It changes the
> 'Uh-gust' to 'Aw-gust', the former being the Hindi (hi_IN)
> pronunciation.
>
>> I've compared the changes with the CLDR database and the changes make
>> our locale match CLDR for on these issues.
>>
>> If nobody objects, I'd say go ahead and check this in at the end of
>> the week.  If someone objects, they we need to document how and why
>> we're diverging from CLDR.
>
> Thanks, I did not know about the CLDR database.  I'll check this in on
> Friday if nobody objects till then.

This patch looks good to me. As a native speaker you have the utmost
advantage when reviewing changes like this, as I had when reviewing
Jeff's Spanish related locale changes.

I would go one step further than Jeff does and say that we should be
working with CLDR to reduce our difference to zero. The fact that you
match CLDR is a good indication of correctness.

Please check this in with an updated ChangeLog talking about fixing
August.

I'm shocked that Wednesday has been written as Tuesday for the last
12 years in mr_IN :-( I assume it speaks to the size of distro local
patches which fix things like this...

Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]