This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/3] Add string IFUNC tests


On Monday, October 15, 2012 14:30:13 H.J. Lu wrote:
> On Mon, Oct 15, 2012 at 1:26 AM, Andreas Jaeger <aj@suse.com> wrote:
> > On 10/12/2012 02:05 AM, H.J. Lu wrote:
> >> [...]
> >> 
> >> diff --git a/string/test-strstr-ifunc.c
> >> b/string/test-strstr-ifunc.c
> >> new file mode 100644
> >> index 0000000..559646a
> >> --- /dev/null
> >> +++ b/string/test-strstr-ifunc.c
> >> @@ -0,0 +1,2 @@
> >> +#define TEST_IFUNC 1
> >> +#include "test-strstr.c"
> > 
> > The changes looks fine but don't we add to each file now a copyright
> > header and a one line description - even for such small files?
> 
> Is this an OK to install if copyright and short description are added?

Yes, if you also incorporate Roland's Makefile changes from the wcsmbs 
IFUNC tests,

Andreas
-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]