Re: PATCH: optimized sincosf with SSE for x86_64 and x86_32

[Andreas Jaeger <aj at suse dot com>]

On 09/18/2012 03:59 PM, Andreas Jaeger wrote:
> On 09/11/2012 08:27 AM, Dmitrieva Liubov wrote:
> > Ok.
> >
> > So, the attached patch #1 (math.patch) fixes wrong sincos using for
> > subnormal argument everywhere I've found.
> >
> > ChangeLog:
> >
> > 2012-09-11  Liubov Dmitrieva  <liubov.dmitrieva@gmail.com>
> >
> >     * math/s_ccoshf.c: Fix
> >     wrong using of sincosf for subnormal argument.
> >     * math/s_cexpf.c: Likewise.
> >     * math/s_csinf.c: Likewise.
> >     * math/s_csinhf.c: Likewise.
> >     * math/s_ctanf.c: Likewise.
> >     * math/s_ctanhf.c: Likewise.
> >
> >     * math/s_ccosh.c: Fix
> >     wrong using of sincosf for subnormal argument.
> >     * math/s_cexp.c: Likewise.
> >     * math/s_csin.c: Likewise.
> >     * math/s_csinh.c: Likewise.
> >     * math/s_ctan.c: Likewise.
> >     * math/s_ctanh.c: Likewise.
> >
> >     * math/s_ccoshl.c: Fix
> >     wrong using of sincosf for subnormal argument.
> >     * math/s_cexpl.c: Likewise.
> >     * math/s_csinl.c: Likewise.
> >     * math/s_csinhl.c: Likewise.
> >     * math/s_ctanl.c: Likewise.
> >     * math/s_ctanhl.c: Likewise.
> >
> > The attached patch #2 (sincos.patch)  proposes optimized sincosf with
> > SSE2 for x86_32 and x86_64
> > Now all new files have 100644 permissions.
> >
> > ChangeLog for #2:
> >
> > 2012-09-11  Liubov Dmitrieva  <liubov.dmitrieva@gmail.com>
> >
> >     * sysdeps/i386/i686/fpu/multiarch/Makefile (sysdep_routines):
> >     Add s_sincosf-sse2.
> >     * sysdeps/i386/i686/fpu/multiarch/s_sincosf.c: New file.
> >     * sysdeps/i386/i686/fpu/multiarch/s_sincosf-sse2.S: New file.
> >     * sysdeps/ieee754/flt-32/s_sincosf.c (SINCOSF, SINCOSF_FUNC): Add
> > macros
> >     for using routine as __sincosf_ia32.
> >     Use macro for function declaration and weak_alias.
> >     * sysdeps/i386/fpu/libm-test-ulps: Update.
> >
> >     * sysdeps/x86_64/fpu/s_sincosf.S: New file.
> >     * sysdeps/x86_64/fpu/libm-test-ulps: Update.
> >
> > No any new fails for "make check", I've already posted information
> > about performance here:
>
> Thanks, this is fine.
>
> I'm currently travelling and therefore can't test it myself (which I do
> before I commit stuff from others), so this has to wait until next week
> (ping me on the 25th). If somebody else likes to commit this, you're
> more than welcome,

I've committed this now,

Andreas
--
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126