This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] [BZ #10631] Clarify malloc error diagnostics to avoid confusion
- From: Siddhesh Poyarekar <siddhesh dot poyarekar at gmail dot com>
- To: libc-alpha at sourceware dot org
- Date: Tue, 18 Sep 2012 07:54:00 +0530
- Subject: Re: [PATCH] [BZ #10631] Clarify malloc error diagnostics to avoid confusion
- References: <20120917231013.GD22320@altlinux.org>
On 18 September 2012 04:40, Dmitry V. Levin <ldv@altlinux.org> wrote:
> diff --git a/ChangeLog b/ChangeLog
> index bb46639..cb51d10 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,8 @@
> +2012-09-17 Dmitry V. Levin <ldv@altlinux.org>
> +
> + [BZ #10631]
> + * malloc.c (malloc_printerr): Clarify error message.
> +
> 2012-09-17 Chris Metcalf <cmetcalf@tilera.com>
>
> * crypt/md5test-giant.c (TIMEOUT): Increase to 8 minutes for tilegx.
Please review the process in the following wiki link and use it for
your submissions:
http://sourceware.org/glibc/wiki/Contribution%20checklist
For example, the following points are incorrect in your submission:
* ChangeLog should not be posted as part of the patch
* Your submission needs a brief description of what you're trying to fix
> __libc_message (action & 2,
> - "*** glibc detected *** %s: %s: 0x%s ***\n",
> + "*** glibc has detected an error in %s: %s: 0x%s ***\n",
> __libc_argv[0] ?: "<unknown>", str, cp);
> }
> else if (action & 2)
The change is trivial but it may break scripts and diagnostic
utilities that may be using the earlier format.
--
http://siddhesh.in