Re: [PATCH] i386/x86_64: punt HAVE_CPP_ASM_DEBUGINFO

[Mike Frysinger <vapier at gentoo dot org>]

On Saturday 15 September 2012 16:10:36 H.J. Lu wrote:
> On Sat, Sep 15, 2012 at 12:39 PM, H.J. Lu wrote:
> > On Sun, Aug 12, 2012 at 12:28 PM, Mike Frysinger wrote:
> >> Pretty sure we require recent enough versions of gcc/binutils to make
> >> this check pointless.  I can't any logs in the last few years where
> >> this check didn't return "yes".
> >> 
> >> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> >> 
> >> 2012-08-12  Mike Frysinger  <vapier@gentoo.org>
> >> 
> >>         * config.h.in (HAVE_CPP_ASM_DEBUGINFO): Delete.
> >>         * sysdeps/i386/configure.in: Remove assembler-with-cpp debug
> >>         check. * sysdeps/i386/configure: Regenerated.
> >>         * sysdeps/i386/sysdep.h (ENTRY): Remove calls to
> >>         STABS_CURRENT_FILE1, STABS_CURRENT_FILE, and STABS_FUN.
> >>         (END): Remove call to STABS_FUN_END.
> >>         (STABS_CURRENT_FILE1): Delete.
> >>         (STABS_CURRENT_FILE): Likewise.
> >>         (STABS_FUN): Likewise.
> >>         (STABS_FUN_END): Likewise.
> >>         (STABS_FUN2): Likewise.
> >>         * sysdeps/x86_64/configure.in: Remove assembler-with-cpp debug
> >>         check. * sysdeps/x86_64/configure: Regenerated.
> > 
> > This caused:
> > 
> > http://sourceware.org/bugzilla/show_bug.cgi?id=14587
> > 
> > We now have
> > 
> > config.make.in:have-cpp-asm-debuginfo = @libc_cv_cpp_asm_debuginfo@
> > configure:libc_cv_cpp_asm_debuginfo
> > configure.in:AC_SUBST(libc_cv_cpp_asm_debuginfo)
> > Makeconfig:ifeq ($(have-cpp-asm-debuginfo),yes)
> > 
> > Since libc_cv_cpp_asm_debuginfo is never yes, we never generate
> > debug info for assembly codes.
> 
> I checked in this as an obvious fix.

thanks!
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.