This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] i386/x86_64: punt HAVE_CPP_ASM_DEBUGINFO
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Sat, 15 Sep 2012 13:10:36 -0700
- Subject: Re: [PATCH] i386/x86_64: punt HAVE_CPP_ASM_DEBUGINFO
- References: <1344799680-19443-1-git-send-email-vapier@gentoo.org><CAMe9rOq=E9iwNn+N0_oM-pGXUtyhT66xWoX=MEZW=TcgJrwW3Q@mail.gmail.com>
On Sat, Sep 15, 2012 at 12:39 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Sun, Aug 12, 2012 at 12:28 PM, Mike Frysinger <vapier@gentoo.org> wrote:
>> Pretty sure we require recent enough versions of gcc/binutils to make this
>> check pointless. I can't any logs in the last few years where this check
>> didn't return "yes".
>>
>> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>>
>> 2012-08-12 Mike Frysinger <vapier@gentoo.org>
>>
>> * config.h.in (HAVE_CPP_ASM_DEBUGINFO): Delete.
>> * sysdeps/i386/configure.in: Remove assembler-with-cpp debug check.
>> * sysdeps/i386/configure: Regenerated.
>> * sysdeps/i386/sysdep.h (ENTRY): Remove calls to STABS_CURRENT_FILE1,
>> STABS_CURRENT_FILE, and STABS_FUN.
>> (END): Remove call to STABS_FUN_END.
>> (STABS_CURRENT_FILE1): Delete.
>> (STABS_CURRENT_FILE): Likewise.
>> (STABS_FUN): Likewise.
>> (STABS_FUN_END): Likewise.
>> (STABS_FUN2): Likewise.
>> * sysdeps/x86_64/configure.in: Remove assembler-with-cpp debug check.
>> * sysdeps/x86_64/configure: Regenerated.
>
> This caused:
>
> http://sourceware.org/bugzilla/show_bug.cgi?id=14587
>
> We now have
>
> config.make.in:have-cpp-asm-debuginfo = @libc_cv_cpp_asm_debuginfo@
> configure:libc_cv_cpp_asm_debuginfo
> configure.in:AC_SUBST(libc_cv_cpp_asm_debuginfo)
> Makeconfig:ifeq ($(have-cpp-asm-debuginfo),yes)
>
> Since libc_cv_cpp_asm_debuginfo is never yes, we never generate
> debug info for assembly codes.
>
I checked in this as an obvious fix.
--
H.J.
---
diff --git a/ChangeLog b/ChangeLog
index cc6cf64..b214afc 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2012-09-14 H.J. Lu <hongjiu.lu@intel.com>
+
+ [BZ #14587]
+ * Makeconfig (ASFLAGS): Remove $(have-cpp-asm-debuginfo) check.
+ * config.make.in (have-cpp-asm-debuginfo): Removed.
+ * configure.in: Don't substitute libc_cv_cpp_asm_debuginfo.
+ * configure: Regenerated.
+
2012-09-14 Joseph Myers <joseph@codesourcery.com>
[BZ #5044]
diff --git a/Makeconfig b/Makeconfig
index 3ed9746..8d4f7b4 100644
--- a/Makeconfig
+++ b/Makeconfig
@@ -801,11 +801,7 @@ endif
# The assembler can generate debug information too.
ifndef ASFLAGS
-ifeq ($(have-cpp-asm-debuginfo),yes)
ASFLAGS := $(filter -g% -fdebug-prefix-map=%,$(CFLAGS))
-else
-ASFLAGS :=
-endif
endif
ASFLAGS += $(ASFLAGS-config) $(asflags-cpu)
diff --git a/NEWS b/NEWS
index c0ef036..adcb741 100644
--- a/NEWS
+++ b/NEWS
@@ -13,7 +13,8 @@ Version 2.17
13542, 13717, 13696, 13939, 13966, 14042, 14090, 14166, 14150, 14151,
14154, 14157, 14166, 14173, 14195, 14237, 14252, 14283, 14298, 14303,
14307, 14328, 14331, 14336, 14337, 14347, 14349, 14459, 14476, 14505,
- 14510, 14516, 14518, 14519, 14532, 14538, 14544, 14545, 14576, 14583
+ 14510, 14516, 14518, 14519, 14532, 14538, 14544, 14545, 14576, 14583,
+ 14587
* Support for STT_GNU_IFUNC symbols added for s390 and s390x.
Optimized versions of memcpy, memset, and memcmp added for System z10 and
diff --git a/config.make.in b/config.make.in
index d84fe38..b6d1c94 100644
--- a/config.make.in
+++ b/config.make.in
@@ -55,7 +55,6 @@ have-Bgroup = @libc_cv_Bgroup@
with-fp = @with_fp@
old-glibc-headers = @old_glibc_headers@
unwind-find-fde = @libc_cv_gcc_unwind_find_fde@
-have-cpp-asm-debuginfo = @libc_cv_cpp_asm_debuginfo@
have-forced-unwind = @libc_cv_forced_unwind@
have-fpie = @libc_cv_fpie@
have-mfma4 = @libc_cv_cc_fma4@
diff --git a/configure b/configure
index d159ce0..739d2bd 100755
--- a/configure
+++ b/configure
@@ -589,7 +589,6 @@ libc_cv_cc_novzeroupper
libc_cv_cc_sse2avx
libc_cv_cc_avx
libc_cv_cc_sse4
-libc_cv_cpp_asm_debuginfo
libc_cv_forced_unwind
libc_cv_rootsbindir
libc_cv_localstatedir
@@ -7500,7 +7499,6 @@ fi
-
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether -fPIC is default" >&5
$as_echo_n "checking whether -fPIC is default... " >&6; }
if ${libc_cv_pic_default+:} false; then :
diff --git a/configure.in b/configure.in
index a174646..878bf1a 100644
--- a/configure.in
+++ b/configure.in
@@ -2147,7 +2147,6 @@ AC_SUBST(libc_cv_rootsbindir)
AC_SUBST(libc_cv_forced_unwind)
dnl sysdeps/CPU/configure.in checks set this via arch-specific asm tests
-AC_SUBST(libc_cv_cpp_asm_debuginfo)
AC_SUBST(libc_cv_cc_sse4)
AC_SUBST(libc_cv_cc_avx)
AC_SUBST(libc_cv_cc_sse2avx)