This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Remove _G_HAVE_PRINTF_FP
- From: "Carlos O'Donell" <carlos at systemhalted dot org>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 12 Sep 2012 22:50:28 -0400
- Subject: Re: Remove _G_HAVE_PRINTF_FP
- References: <Pine.LNX.4.64.1209130001170.15730@digraph.polyomino.org.uk>
On Wed, Sep 12, 2012 at 8:02 PM, Joseph S. Myers
<joseph@codesourcery.com> wrote:
> The macro _G_HAVE_PRINTF_FP in _G_config.h is only used in a condition
> on whether to define _IO_USE_DTOA in libio.h. Nothing in glibc uses
> _IO_USE_DTOA. So both macros are effectively unused, and this patch
> removes them. Tested on x86_64 that it makes no difference to the
> code generated for glibc's shared libraries.
>
> 2012-09-12 Joseph Myers <joseph@codesourcery.com>
>
> * libio/libio.h [!_G_HAVE_PRINTF_FP] (_IO_USE_DTOA): Remove.
> * sysdeps/generic/_G_config.h (_G_HAVE_PRINTF_FP): Likewise.
> * sysdeps/gnu/_G_config.h (_G_HAVE_PRINTF_FP): Likewise.
> * sysdeps/mach/hurd/_G_config.h (_G_HAVE_PRINTF_FP): Likewise.
This looks good to me.
I reviewed this code and the *old* libstdc++ code
that used to use _IO_USE_DTOA, and it's long gone
and unused now.
Thanks for the good cleanup.
Cheers,
Carlos.