This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH: optimized sincosf with SSE for x86_64 and x86_32
On Saturday, September 08, 2012 23:07:11 Dmitrieva Liubov wrote:
> I propose a big patch with the following new features and fixes:
>
> 1. SSE optimized sincosf for x86_64 with excellent performance
> results. 2. SSE optimized sincosf for x86_32 with excellent
> performance results. 3. Some minor fixes in already merged sinf and
> cosf (unwind info and the description of special cases in the
> comment).
Let's break out 3. of this patch to make it smaller.
This is the changes entry:
> * sysdeps/i386/i686/fpu/multiarch/s_sinf-sse2.S: Fix
> unwind info if defined PIC. Fix special cases description.
> * sysdeps/i386/i686/fpu/multiarch/s_cosf-sse2.S: Likewise.
> * sysdeps/x86_64/fpu/s_sinf.S: Fix
> special cases description.
> * sysdeps/x86_64/fpu/s_cosf.S: Likewise.
The changelog misses: Fix DP_HI_MASK entry, I'll add that.
I'll commit this now on your behalf, the changes look fine.
Btw. some of your new files have:
new file mode 100755
All should be 100644, please check the permissions.
Thanks,
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126