This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] BZ #14251: Add name_to_handle_at, open_by_handle etc.to PowerPC bits/fcntl.h.
- From: Carlos O'Donell <carlos at systemhalted dot org>
- To: Khem Raj <raj dot khem at gmail dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Sun, 09 Sep 2012 11:38:08 -0400
- Subject: Re: [PATCH] BZ #14251: Add name_to_handle_at, open_by_handle etc.to PowerPC bits/fcntl.h.
- References: <1347164950-18557-1-git-send-email-raj.khem@gmail.com>
On 9/9/2012 12:29 AM, Khem Raj wrote:
> ---
> 2012-09-08 Khem Raj <raj.khem@gmail.com>
>
> [BZ #14251]
> * sysdeps/unix/sysv/linux/powerpc/bits/fcntl.h: Define struct
> file_handle and MAX_HANDLE_SZ. Declare name_to_handle_at and
> open_by_handle.
>
Imagine your email is like an assignment, you need to do everything
you can so I can give you an "A" :-)
Please explain what's going on and summarize the results of your
analysis for BZ #14251 so I Can easily review your patch.
e.g.
http://sourceware.org/glibc/wiki/Contribution%20checklist#Detailed_Explanation_of_the_Patch
* How do you know MAX_HANDLE_SZ is correct?
* Testing?
* What does the Power maintainer have to say? I don't see Ryan or others on the CC.
Thanks for the work!
Cheers,
Carlos.