This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PING: [PATCH] BZ #14544: Use crtbeginT.o to statically link programs


On Thu, Sep 6, 2012 at 9:11 AM, Carlos O'Donell
<carlos_odonell@mentor.com> wrote:
> On 9/6/2012 9:28 AM, H.J. Lu wrote:
>> On Thu, Sep 6, 2012 at 6:20 AM, Carlos O'Donell
>> <carlos_odonell@mentor.com> wrote:
>>> On 9/6/2012 8:50 AM, H.J. Lu wrote:
>>>> On Tue, Sep 4, 2012 at 7:58 PM, H.J. Lu <hongjiu.lu@intel.com> wrote:
>>>>> Hi,
>>>>>
>>>>> We should use crtbeginT.o instead of crtbegin.o to statically link
>>>>> programs.  Tested on Linux/x86-64.  OK to install?
>>>
>>> How is it that this doesn't cause serious problems in the testsuite?
>>>
>>> It is just that we are lucky (looking at the disassembly shows that might be the case)?
>>
>> That is pure luck.
>
> That's what I thought.
>
>>> What's this history here?
>>>
>>> When did this change in upstream?
>>
>> It was added to GCC 3.1 by
>>
>> http://gcc.gnu.org/ml/gcc-patches/2001-12/msg01552.html
>>
>> to support .eh_frame_hdr section.
>>
>>> Is crtbeginT.o used by all gcc's that we support?
>>
>> We require GCC 4.3 or newer.
>>
>>> Could you please verify this works fine on x86 also?
>>
>> It works on x86, x32 and x86-64.
>
> Thanks for verifying this.
>
> Could you please find one other person to review this?
>
> I suggest Andreas, Roland, or pick a random person from MAINTAINERS :-)
>

Roland is out this week.  Andreas, Mike, can you take a look?

Thanks.


-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]