This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] S/390: Fix two issues with the IFUNC optimized mem* routines

On Fri, Aug 31, 2012 at 7:40 AM, Richard Henderson <rth@twiddle.net> wrote:
> On 08/30/2012 06:02 PM, H.J. Lu wrote:
>> @@ -3470,6 +3470,25 @@ elf_i386_relocate_section (bfd *output_bfd,
>
> Don't do these sorts of things in relocate_section.
>
> Do them in relax_section where you still have time
> to remove the got entry if it becomes unused.
>

This is an excellent idea.  But  relax_section is too late for
x86 and x86-64.  I need to do it in size_dynamic_sections
so that we can get proper GOT entries.


-- 
H.J.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]