This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: ARM hard-float ABI: add ldconfig flag value

On Thu, 23 Aug 2012, Steve McIntyre wrote:

> OK, here's the updated patch with the name change and tweaks to
> style. All OK?

I've fixed further coding style issues and added ChangeLog entries and 
committed the patch:

> +#ifdef __ARM_PCS_VFP
> +#define VALID_FLOAT_ABI(x) \
> +  ((EF_ARM_EABI_VERSION ((x)) != EF_ARM_EABI_VER5)	\
> +   || !((x) & EF_ARM_ABI_FLOAT_SOFT))

Space between "#" and "define" inside #if.

>     || memcmp (hdr, expected2, size) == 0	\
> -   || memcmp (hdr, expected3, size) == 0)
> +    || memcmp (hdr, expected3, size) == 0)	\

The first quoted line here also needs the extra indentation to adjust for 
the added parentheses.

-- 
Joseph S. Myers
joseph@codesourcery.com
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]