This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix up bswap_* types
> > Note that endian.h is not specified by any published standard.
> > You cited materials of the POSIX working group that indicate how
> > it's expected to be specified in a future edition of POSIX.1, but
> > until such an edition is actually finalized, we're still dealing
> > with an <endian.h> that is a GNU invention.
>
> Sorry about that. Although I think that proposal looks fine.
So do I (it's just standardizing what we invented). I was just making
the point about giving the impression of citing a standard when that's
not quite what it is.
> I did that, hopefully. I moved #include <stdint.h> into
> string/byteswap.h and into string/endian.h.
> Does this look ok? Tested x86_64.
Some of your ChangeLog lines are too long (wrap at column 79 or
before). Otherwise it looks fine to me. But please test an i686
build too, and the s390 changes need the s390 maintainer's sign-off.
Thanks,
Roland